Default Ruby version to 2.6.5 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/bump-default-ruby-versions
branch
2 times, most recently
from
3312266 to
693be9e
Compare
- Skip the naether test which is failing for unknown reasons that need further investigation - Change the description so that only tests that use `cedar-14` have it in the description
schneems
force-pushed
the
schneems/bump-default-ruby-versions
branch
from
693be9e to
6b7f38c
Compare
Because Ruby 2.6.5 ships with Bundler 2 it also includes a check for bundler version and will error if the version does not match. This commit bumps up the logic of when the BUNDLED WITH lines in the Gemfile.lock get removed so they allow the Buildpack to execute correctly.
schneems
force-pushed
the
schneems/bump-default-ruby-versions
branch
from
cd8d86a to
4b3bfc6
Compare
danielleadams
approved these changes
Jan 30, 2020
That app fails with Postgres 12 errors with the message:
```
/time_zone.rb:270: warning: circular argument reference - now
-- initialize_schema_migrations_table()
rake aborted!
ActiveRecord::StatementInvalid: PG::InvalidParameterValue: ERROR: invalid value for parameter "client_min_messages": "panic"
HINT: Available values: debug5, debug4, debug3, debug2, debug1, log, notice, warning, error.
: SET client_min_messages TO 'panic'
/app/vendor/bundle/ruby/2.6.0/gems/activerecord-3.1.12/lib/active_record/connection_adapters/postgresql_adapter.rb:605:in `async_exec'
/app/vendor/bundle/ruby/2.6.0/gems/activerecord-3.1.12/lib/active_record/connection_adapters/postgresql_adapter.rb:605:in `block in execute'
/app/vendor/bundle/ruby/2.6.0/gems/activerecord-3.1.12/lib/active_record/connection_adapters/abstract_adapter.rb:245:in `block in log'
/app/vendor/bundle/ruby/2.6.0/gems/activesupport-3.1.12/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
```
This commit locks it to a specific Postgres version (Postgres 11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.