Make version warnings more robust #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/less-agressive-warning
branch
3 times, most recently
from
6517b40
to
f59eac1
Compare
Users are mistakenly getting this warning when building apps:
```
Your Ruby version is not present on the next stack
You are currently using ruby-2.6.5 on heroku-16 stack.
This version does not exist on heroku-18. In order to upgrade your stack you will
need to upgrade to a supported Ruby version.
For a list of supported Ruby versions see:
https://devcenter.heroku.com/articles/ruby-support#supported-runtimes
For a list of the oldest Ruby versions present on a given stack see:
https://devcenter.heroku.com/articles/ruby-support#oldest-available-runtimes
```
I believe this is a result of network glitches. We should be cautious about warning about issues that don't actually exist.
schneems
force-pushed
the
schneems/less-agressive-warning
branch
from
f59eac1
to
5017ce0
Compare
Malax
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are mistakenly getting this warning when building apps:
I believe this is a result of network glitches. We should be cautious about warning about issues that don't actually exist.