Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 2.6.6 is the new default #974

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Ruby 2.6.6 is the new default #974

merged 1 commit into from
Apr 2, 2020

Conversation

schneems
Copy link
Contributor

No description provided.

@schneems
Copy link
Contributor Author

Depends on #973

@schneems schneems force-pushed the schneems/default_266 branch 2 times, most recently from 5e9a1e0 to db73553 Compare April 1, 2020 17:57
@schneems schneems force-pushed the schneems/default_266 branch from db73553 to 977f318 Compare April 1, 2020 21:20
CaseyFaist
CaseyFaist approved these changes Apr 2, 2020
View reviewed changes
Copy link

@CaseyFaist CaseyFaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look good. This is a lot of things to update for a default version change though - is this process documented anywhere?

@schneems
Copy link
Contributor Author

schneems commented Apr 2, 2020

is this process documented anywhere?

Not really. If you change one place then tests start failing so at least that's a guiding light.

@schneems schneems merged commit 112fa80 into master Apr 2, 2020
@schneems schneems deleted the schneems/default_266 branch April 2, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyFaist CaseyFaist CaseyFaist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneems @CaseyFaist