Fix bug when doing an version check with \timing on #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will depend on heroku/cli#1801 being released |
andscoop
changed the title
|
@andscoop just noticed the depending PR got merged! There are some conflicts now but should we go ahead with this? We've seen another case where PG version detection isn't correct (although I haven't been able to find why yet) and I think this should fix it too. |
andscoop
force-pushed
the
fsre/version-check-works-with-timing-off
branch
from
abeb0c2 to
d93b6b2
Compare
tevanoff
reviewed
Feb 21, 2022
tevanoff
reviewed
Feb 21, 2022
Co-authored-by: Todd Evanoff <evanoff@gmail.com>
Co-authored-by: Todd Evanoff <evanoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the version check to execute with or without
\timingenabled while still allowing us to guard against index out of range errors.Fixes: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000008x6klIAA/view