Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(W-17632498,W-17632503): search broken, add feedback with no results #117

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(W-17632498,W-17632503): search broken, add feedback with no results #117

merged 1 commit into from
Feb 14, 2025

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Feb 14, 2025 •
edited
Loading

This PR addresses the following:

  1. Search does not always work in the starter repos view
  2. No feedback when searching yields zero results

Testing

  1. Run the extension
  2. Navigate to the stater repos view - Ctrl + P then type >Heroku apps: Browse
  3. Try several search term in the search view
  4. Observe searching works as expected with feedback when no results are found.
    W-17632498
    W-17632503

k80bowman
k80bowman approved these changes Feb 14, 2025
View reviewed changes
Copy link

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@justinwilaby justinwilaby merged commit 41e9f9f into main Feb 14, 2025
1 check passed
@justinwilaby justinwilaby deleted the jw/fix/W-17632498 branch February 14, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinwilaby @k80bowman