-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets input to buildpack release #157
base: main
Are you sure you want to change the base?
Conversation
@@ -59,7 +69,7 @@ env: | |||
jobs: | |||
compile: | |||
name: Compile Buildpacks | |||
runs-on: ubuntu-latest | |||
runs-on: ${{ inputs.ip_allowlisted_runner }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowlisted runner is only needed for jobs that interact with the certain repositories. The compile job does not require this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need this to pull the languages-github-actions lockfile from the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a public repo, so not sure why that's needed? (Given it's not an API call) Strange :-)
curl --silent --show-error --fail --retry 5 --retry-all-errors --connect-timeout 10 --max-time 60 "${LOCKFILE_URL}" \ | ||
| yq -ptoml -oyaml '.package[] | select(.name == "libcnb-package") | .version' \ | ||
) | ||
if [ "${{ inputs.libcncb_cargo_version }}" == "default" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in inputs.libcncb_cargo_version
@hone The libcnb 0.15.0 upgrade has now been merged to |
This is the first step in building multiple architectures by being able to produce
.cnb
s for different architectures for a buildpack.