Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targets input to buildpack release #157

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Add targets input to buildpack release #157

wants to merge 23 commits into from

Conversation

hone
Copy link
Member

@hone hone commented Oct 10, 2023

This is the first step in building multiple architectures by being able to produce .cnbs for different architectures for a buildpack.

@hone hone requested a review from a team as a code owner October 10, 2023 23:32
@hone hone marked this pull request as draft October 10, 2023 23:32
@@ -59,7 +69,7 @@ env:
jobs:
compile:
name: Compile Buildpacks
runs-on: ubuntu-latest
runs-on: ${{ inputs.ip_allowlisted_runner }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowlisted runner is only needed for jobs that interact with the certain repositories. The compile job does not require this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need this to pull the languages-github-actions lockfile from the repo.

Copy link
Member

@edmorley edmorley Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a public repo, so not sure why that's needed? (Given it's not an API call) Strange :-)

curl --silent --show-error --fail --retry 5 --retry-all-errors --connect-timeout 10 --max-time 60 "${LOCKFILE_URL}" \
| yq -ptoml -oyaml '.package[] | select(.name == "libcnb-package") | .version' \
)
if [ "${{ inputs.libcncb_cargo_version }}" == "default" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in inputs.libcncb_cargo_version

@edmorley
Copy link
Member

@hone The libcnb 0.15.0 upgrade has now been merged to main and released - so if you rebase on that, the manual libcnb upgrade related changes won't be needed any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants