Simplify Cargo metadata for publish = false crates
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Cargo 1.75 the `version` property in `Cargo.toml` is now optional, and if omitted is the same as having specified `version = "0.0.0"` and `publish = false`: https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-175-2023-12-28 https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field Therefore for crates that we do not publish, we can now remove both the `version` and `publish` properties, avoiding the need for the fake `0.0.0` version that differs from the actual buildpack version in `buildpack.toml`. GUS-W-14821120.
colincasey
approved these changes
Jan 15, 2024
edmorley
added a commit
that referenced
this pull request
Jan 26, 2024
The `version` and `publish` fields were removed in #181 since they are now optional for crates that are not published to crates.io. However, even though this crate isn't published to crates.io, the `version` field is still used/set as part of the current GitHub Releases publishing process, which uses `cargo-bump` to generate an appropriate new version number based on the major/minor/patch workflow input. Fixes: ``` $ cargo bump 0.3.10 thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-bump-1.1.0/src/main.rs:57:14: toml has version ``` Seen in: https://github.com/heroku/languages-github-actions/actions/runs/7669085052/job/20902261440#step:9:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Cargo 1.75 the
versionproperty inCargo.tomlis now optional, and if omitted is the same as having specifiedversion = "0.0.0"andpublish = false:https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-175-2023-12-28
https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field
Therefore for crates that we do not publish, we can now remove both the
versionandpublishproperties, avoiding the need for the fake0.0.0version that differs from the actual buildpack version inbuildpack.toml.GUS-W-14821120.