Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint failures with Rust 1.70 #574

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jun 9, 2023

Fixes:

error: this is an outer doc comment and does not apply to the parent module or crate
 --> libcnb/src/exit_code.rs:1:1
  |
1 | ///! libcnb exit code constants
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments
  = note: `-D clippy::suspicious-doc-comments` implied by `-D warnings`
help: use an inner doc comment to document the parent module or crate
  |
1 | //! libcnb exit code constants
  |

As seen in:
https://github.com/heroku/libcnb.rs/actions/runs/5218101938/jobs/9418580736?pr=573#step:5:231

See:
https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments

GUS-W-13567582.

Fixes:

```
error: this is an outer doc comment and does not apply to the parent module or crate
 --> libcnb/src/exit_code.rs:1:1
  |
1 | ///! libcnb exit code constants
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments
  = note: `-D clippy::suspicious-doc-comments` implied by `-D warnings`
help: use an inner doc comment to document the parent module or crate
  |
1 | //! libcnb exit code constants
  |
```

As seen in:
https://github.com/heroku/libcnb.rs/actions/runs/5218101938/jobs/9418580736?pr=573#step:5:231

GUS-W-13567582.
@edmorley edmorley self-assigned this Jun 9, 2023
@edmorley edmorley marked this pull request as ready for review June 9, 2023 07:54
@edmorley edmorley requested a review from a team as a code owner June 9, 2023 07:54
@edmorley
Copy link
Member Author

edmorley commented Jun 9, 2023

Force merging since this is currently failing on main (and thus blocks things like the Dependabot PRs), is a trivial change, and everyone who might review this change is PTO or out of hours.

@edmorley edmorley merged commit 29ffc58 into main Jun 9, 2023
@edmorley edmorley deleted the edmorley/fix-lints-rust-1.70 branch June 9, 2023 08:01
colincasey added a commit that referenced this pull request Jun 12, 2023
* main:
  Update fastrand requirement from 1.8.0 to 2.0.0 (#573)
  Fix lint failures with Rust 1.70 (#574)
  Bump Swatinem/rust-cache from 2.3.0 to 2.4.0 (#572)
  Bump Swatinem/rust-cache from 2.2.1 to 2.3.0 (#571)
  Bump buildpacks/github-actions from 5.1.0 to 5.2.0 (#569)
  Prepare 0.12.0 release (#568)
  Support Buildpack API `0.9` (#567)
  Add Clone for Scope (#566)
  Improve Env::get, add Env::get_string_lossy (#565)
  Bump buildpacks/github-actions from 5.0.1 to 5.1.0 (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant