libcnb-test: Only expose ports to localhost #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ports exposed using `ContainerConfig::expose_port` would be exposed to the internet, rather than just localhost. See: https://docs.docker.com/network/#published-ports Fixes #609. GUS-W-13812521.
edmorley
changed the title
edmorley
changed the title
Malax
reviewed
Jul 24, 2023
Malax
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ports exposed using
ContainerConfig::expose_portwould be exposed to the internet, rather than just localhost.Sadly the Bollard docs don't mention this pitfall:
https://docs.rs/bollard/latest/bollard/models/struct.PortBinding.html
See:
https://docs.docker.com/engine/reference/commandline/run/#publish
https://docs.docker.com/network/#published-ports
Fixes #609.
GUS-W-13812521.