libcnb-test: Fix image cleanup when a pack build unexpectedly succeeds #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a test with an expected result of `PackResult::Failure` unexpectedly succeeded, the built app image was left behind since cleanup was only performed in `TestContext::Drop` (and in this scenario, a `TestContext` is never created in the first place). Now the app image is correctly cleaned up. Fixes #586. Closes #588. GUS-W-13903181.
edmorley
added a commit
that referenced
this pull request
Aug 8, 2023
Since #625 was a bug fix not a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a test with an expected result of
PackResult::Failureunexpectedly succeeded, the built app image was left behind since cleanup was only performed inTestContext::Drop(and in this scenario, aTestContextis never created in the first place).Now the app image is correctly cleaned up.
This scenario is hard to write a test for unless we resort to
std::panic::catch_unwindand manual Docker inspect subprocess calls, which is not really worth it - so I've just tested manually instead.Fixes #586.
Closes #588.
GUS-W-13903181.