WIP: Fix #209 missing component ref #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villesau
force-pushed
the
fix-missing-component-ref-issue-209
branch
from
0879b7d
to
1ad0996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209 for most of the cases. For initial render the ref is still missing. But that's a problem mostly in case of mock data only I think. Proper fix for that would be to move fetch dispatching to componentDidMount instead of componentWillMount but that change might be controversial.
Also unified handling in case of values as I didn't see purpose to explicitly call
thenwith custom logic as it's handled in createPromiseStateOnFulfillment anyways. If there is purpose, please let me know!Also wondering what removes the component from meta if it's not defined in fetch calls then too.
TODO: tests