Publish Types #220
Merged
Publish Types #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `index.d.ts` into `src`, next to `index.js` - At build time, move `index.d.ts` to `lib`, next to the transpiled `index.js` - Register `./lib/index.d.ts` as main type file in `package.json`
Merged
|
References fine for me in VSCode. Tested by deleting the types we're using, right clicking an import and going to declaration, which takes me to We don't use every library feature exhaustively but I imported everything and there were no compiler errors across our whole project. I think this is good to go 🙂 |
|
@lmontoute Awesome, thanks for testing that out. I'll get this out as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219 introduced types, but as mentioned in #219 (comment), they aren't actually published anywhere.
This makes the following changes (a little different than discussed in #219 (comment), but I think this way is cleaner):
index.d.tsintosrc, next toindex.jsindex.d.tstolib, next to the transpiledindex.js./lib/index.d.tsas main type file inpackage.jsonTo help test this out, I have published this as beta version
2.0.2-0. @lmontoute or @hburrows, can you test this out on your projects?cc: @ipanasenko