Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

couple changes for detecting errors #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

leafo
Copy link

@leafo leafo commented Feb 5, 2012

There's a few things in here, feel free to cherry pick what you want and throw out the rest.

First, I made sure prefix is created as a directory before building. I had a build script that didn't create it and it was unclear what the error was until I annotated the code.

Second, I save the output from the build command into couch. This is useful if it does build but not correctly. That way you can at least see what happened during the build in the couch web interface or something.

The last three commits capture any exceptions for the make ruby script and save them into couch. Then when you try to get the output via /output/ it checks if there was an error and tells you what it was. Before this patch, the make script would silently fail, and the only error message I would get would be about the missing output attachment.

And a related question. Why is the make script done in ruby? I am kind of new to Heroku so maybe I am missing something but I didn't see a way to capture the output from it. So in my case, things were going wrong but I couldn't tell because the failures were silently ignored.

Thanks for the project.

@ddollar
Copy link
Contributor

ddollar commented Jun 25, 2012

Sorry I'm getting to this pull request so late. If you're still interested, would you mind rebasing it against master and I'd be happy to merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants