chore(select): code imrovement, wkw's suggestions

heroui-inc · Oct 7, 2024 · 57bfd32 · 57bfd32
1 parent c3c475c
commit 57bfd32
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.changeset/dull-bags-divide.md b/.changeset/dull-bags-divide.md
@@ -2,4 +2,4 @@
 "@nextui-org/select": patch
 ---
 
-The PR makes changes to use the label placement in select according to the shouldLabelBeOutside rather than isOutsideLeft. This resolves the label placement issues in case of multiline.(fixes issue: #3841)
+The PR updates label placement in select components to use shouldLabelBeOutside instead of isOutsideLeft, resolving multiline label placement issues (#3841).
diff --git a/packages/components/select/__tests__/select.test.tsx b/packages/components/select/__tests__/select.test.tsx
@@ -721,7 +721,7 @@ describe("Select", () => {
     });
   });
 
-  it("should place the label outside when labelPlacement is outside", async () => {
+  it("should place the label outside when labelPlacement is outside", () => {
     const labelContent = "Favorite Animal Label";
 
     render(
@@ -751,7 +751,7 @@ describe("Select", () => {
     expect(trigger).not.toHaveTextContent(labelContent);
   });
 
-  it("should place the label inside when labelPlacement prop is not passed", async () => {
+  it("should place the label inside when labelPlacement prop is not passed", () => {
     const labelContent = "Favorite Animal Label";
 
     render(