-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom-styles.ts #2982
Update custom-styles.ts #2982
Conversation
The data attribute as per the documentation of input is data-focus. In this code demo it is portrayed as data-focused which does not work.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kknownymouss is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe modifications involve updating CSS class selectors in a styling file for a documentation component. The primary change is the adjustment of the pseudo-class from Changes
Overall, the PR aims to correct a specific error in a code example related to data attributes on an input element, ensuring it aligns with the proper documentation standards. The incomplete sections suggest that further details were intended to be added but were not included at the time of this summary. --> Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/docs/content/components/input/custom-styles.ts (1 hunks)
Additional comments not posted (1)
apps/docs/content/components/input/custom-styles.ts (1)
55-56
: Updated attribute selectors from[focused=true]
to[focus=true]
to match documentation.This change ensures that the CSS class selectors correctly apply styles based on the updated attribute, improving the consistency and functionality of the focus state styling.
The data attribute as per the documentation of input is data-focus. In this code demo it is portrayed as data-focused which does not work.
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit