Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-styles.ts #2982

Merged
merged 1 commit into from
May 13, 2024
Merged

Update custom-styles.ts #2982

merged 1 commit into from
May 13, 2024

Conversation

kknownymouss
Copy link
Contributor

@kknownymouss kknownymouss commented May 11, 2024

The data attribute as per the documentation of input is data-focus. In this code demo it is portrayed as data-focused which does not work.

Closes #

📝 Description

Add a brief description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Style
    • Updated the visual styling for focused input components in both light and dark modes.

The data attribute as per the documentation of input is data-focus. In this code demo it is portrayed as data-focused which does not work.
@kknownymouss kknownymouss requested a review from jrgarciadev as a code owner May 11, 2024 22:04
Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: 6336746

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 10:06pm

Copy link

vercel bot commented May 11, 2024

@kknownymouss is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 11, 2024

Walkthrough

The modifications involve updating CSS class selectors in a styling file for a documentation component. The primary change is the adjustment of the pseudo-class from focused to focus, ensuring consistency and potentially correcting a mistake in the state handling of UI components. This affects both the default and dark mode specific styles.

Changes

File Path Change Summary
.../input/custom-styles.ts Updated CSS selectors from [focused=true] to [focus=true] in both default and dark themes.
", suggesting that it is intended to resolve a specific issue, but the exact issue number is not provided in the provided text.

Overall, the PR aims to correct a specific error in a code example related to data attributes on an input element, ensuring it aligns with the proper documentation standards. The incomplete sections suggest that further details were intended to be added but were not included at the time of this summary.

-->


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between cc1d62a and 6336746.
Files selected for processing (1)
  • apps/docs/content/components/input/custom-styles.ts (1 hunks)
Additional comments not posted (1)
apps/docs/content/components/input/custom-styles.ts (1)

55-56: Updated attribute selectors from [focused=true] to [focus=true] to match documentation.

This change ensures that the CSS class selectors correctly apply styles based on the updated attribute, improving the consistency and functionality of the focus state styling.

@jrgarciadev jrgarciadev changed the base branch from main to canary May 13, 2024 02:17
@jrgarciadev jrgarciadev changed the base branch from canary to main May 13, 2024 02:17
@jrgarciadev jrgarciadev merged commit 67553d2 into heroui-inc:main May 13, 2024
2 of 3 checks passed
@wingkwong wingkwong added this to the v2.3.7 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants