fix(table): group action of children of table row #3546
Conversation
🦋 Changeset detectedLatest commit: 551e880 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@abhinandan-verma is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis commit enhances the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
.changeset/stale-tomatoes-compete.md (2)
1-3: Clarify the changeset description.The current description is minimal. Consider adding more details about the changes and their impact.
--- "@nextui-org/theme": patch --- + This patch addresses the issue where disabled or read-only checkboxes in a selectable table incorrectly change their state when a user clicks on the corresponding table row. The update ensures that the group action for all children of a table row behaves correctly, maintaining the state of these checkboxes.
5-5: Improve the commit message.The commit message should be more descriptive and follow conventional commit guidelines.
- fixed the auto toggle of toggle elements in table row([#3544](https://github.com/nextui-org/nextui/issues/3544)) + fix(table): prevent state change of disabled/read-only checkboxes in table row ([#3544](https://github.com/nextui-org/nextui/issues/3544))
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .changeset/brown-days-applaud.md (1 hunks)
- .changeset/stale-tomatoes-compete.md (1 hunks)
- packages/core/theme/src/components/table.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/brown-days-applaud.md
Additional comments not posted (1)
packages/core/theme/src/components/table.ts (1)
Line range hint
42-42:
Ensure the removal of the "group" class does not affect functionality.The removal of the "group" class from the
thelement's class list might impact the styling and behavior of the table headers. Verify that this change does not introduce any unintended side effects.Verification successful
The removal of the "group" class from the
thelement's class list does not affect functionality.The search results indicate that the "group" class is not used in any
thelements across the codebase, confirming that its removal does not introduce any unintended side effects.
- No instances of "group" class usage in
thelements were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing the "group" class from the `th` element's class list. # Test: Search for the usage of the "group" class in the codebase to identify any dependencies. rg --type js --type ts --type tsx -A 5 $'className={th()}'Length of output: 169
Script:
#!/bin/bash # Description: Verify the impact of removing the "group" class from the `th` element's class list. # Test: Search for the usage of the "group" class in the codebase to identify any dependencies. rg --type js --type ts --type tsx 'className=.*group.*'Length of output: 85
Script:
#!/bin/bash # Description: Verify the impact of removing the "group" class from the `th` element's class list. # Test: Search for the usage of the "group" class in the codebase to identify any dependencies. rg --type js --type ts 'className=.*group.*'Length of output: 6772
|
@wingkwong sir review ? |
|
@wingkwong I am sorry, perhaps it was due small mistake |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/core/theme/src/components/table.ts (1 hunks)
Additional context used
GitHub Check: ESLint
packages/core/theme/src/components/table.ts
[warning] 59-59:
Delete·
Additional comments not posted (1)
packages/core/theme/src/components/table.ts (1)
59-59: Verify the impact of removing the "group" class.Removing the "group" class from the
trelement may affect the styling and behavior of table rows. Ensure that this change does not introduce any unintended side effects, especially related to group interactions and visual hierarchy.Tools
GitHub Check: ESLint
[warning] 59-59:
Delete·
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/core/theme/src/components/table.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/core/theme/src/components/table.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .changeset/stale-tomatoes-compete.md (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/stale-tomatoes-compete.md
|
as discussed with Abhinandan, this pr will be closed and I'll take over it. |
Closes #3544
📝 Description
Fixed the group action of all the children of table row
⛳️ Current behavior (updates)
group-toggle-issue.mov
🚀 New behavior
Screen.Recording.2024-07-24.at.11.12.07.AM.mov
💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
Style