Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(sandpack): improved logic for react import #3582

Merged
merged 8 commits into from
Aug 29, 2024
Merged

doc(sandpack): improved logic for react import #3582

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4543e1
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
626e0e0
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
9ae43dd
Merge branch 'nextui-org:canary' into canary
awesome-pro Jul 23, 2024
816e5cb
Merge branch 'nextui-org:canary' into canary
awesome-pro Jul 25, 2024
e4d5155
docs(sandpack): improved logic for react imoprt
awesome-pro Jul 31, 2024
4f9edff
Delete .changeset/brown-days-applaud.md
awesome-pro Jul 31, 2024
e1b0082
Update use-sandpack.ts
awesome-pro Jul 31, 2024
8fa9740
refactor(docs): skip adding import react if not required
wingkwong Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/docs/components/sandpack/use-sandpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,17 @@ export const useSandpack = ({
let fileContent = files[key] as string;

// Check if the file content includes 'React' import statements, if not, add it
if (!fileContent.includes("from 'react'") && !fileContent.includes('from "react"')) {
if (
fileContent.includes("React.") &&
!fileContent.includes("from 'react'") &&
!fileContent.includes('from "react"')
) {
fileContent = `${importReact}\n${fileContent}\n`;
}

// Check if file content includes any other dependencies, if yes, add it to dependencies
const importRegex = /import .* from ["'](.*)["']/g;
let match;
let match: RegExpExecArray | null;

while ((match = importRegex.exec(fileContent)) !== null) {
const dependencyName = match[1];
Expand Down