Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): label placement discrepancy in Select #3853

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-bags-divide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/select": patch
---

The PR makes changes to use the label placement in select according to the shouldLabelBeOutside rather than isOutsideLeft. This resolves the label placement issues in case of multiline.(fixes issue: #3841)
macci001 marked this conversation as resolved.
Show resolved Hide resolved
57 changes: 57 additions & 0 deletions packages/components/select/__tests__/select.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,63 @@ describe("Select", () => {
expect(onChange).toBeCalledTimes(1);
});
});

it("should place the label outside when labelPlacement is outside", async () => {
macci001 marked this conversation as resolved.
Show resolved Hide resolved
const labelContent = "Favorite Animal Label";

render(
<Select
aria-label="Favorite Animal"
data-testid="select"
label={labelContent}
labelPlacement="outside"
placeholder="placeholder"
>
<SelectItem key="penguin" value="penguin">
Penguin
</SelectItem>
<SelectItem key="zebra" value="zebra">
Zebra
</SelectItem>
<SelectItem key="shark" value="shark">
Shark
</SelectItem>
</Select>,
);

const base = document.querySelector("[data-slot=base]");
const trigger = document.querySelector("[data-slot=trigger]");

expect(base).toHaveTextContent(labelContent);
expect(trigger).not.toHaveTextContent(labelContent);
});

it("should place the label inside when labelPlacement prop is not passed", async () => {
macci001 marked this conversation as resolved.
Show resolved Hide resolved
const labelContent = "Favorite Animal Label";

render(
<Select
aria-label="Favorite Animal"
data-testid="select"
label={labelContent}
placeholder="placeholder"
>
<SelectItem key="penguin" value="penguin">
Penguin
</SelectItem>
<SelectItem key="zebra" value="zebra">
Zebra
</SelectItem>
<SelectItem key="shark" value="shark">
Shark
</SelectItem>
</Select>,
);

const trigger = document.querySelector("[data-slot=trigger]");

expect(trigger).toHaveTextContent(labelContent);
});
});

describe("Select with React Hook Form", () => {
Expand Down
6 changes: 3 additions & 3 deletions packages/components/select/src/select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function Select<T extends object>(props: Props<T>, ref: ForwardedRef<HTMLSelectE
endContent,
placeholder,
renderValue,
isOutsideLeft,
shouldLabelBeOutside,
macci001 marked this conversation as resolved.
Show resolved Hide resolved
disableAnimation,
getBaseProps,
getLabelProps,
Expand Down Expand Up @@ -117,10 +117,10 @@ function Select<T extends object>(props: Props<T>, ref: ForwardedRef<HTMLSelectE
return (
<div {...getBaseProps()}>
<HiddenSelect {...getHiddenSelectProps()} />
{isOutsideLeft ? labelContent : null}
{shouldLabelBeOutside ? labelContent : null}
<div {...getMainWrapperProps()}>
<Component {...getTriggerProps()}>
{!isOutsideLeft ? labelContent : null}
{!shouldLabelBeOutside ? labelContent : null}
<div {...getInnerWrapperProps()}>
{startContent}
<span {...getValueProps()}>{renderSelectedItem}</span>
Expand Down