Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): rtl navigation #4565

Merged
6 changes: 6 additions & 0 deletions .changeset/cyan-deers-tap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@heroui/calendar": patch
"@heroui/theme": patch
---

Fixed reversed navigation behavior of nextButton and prevButton in the RTL calendar. The buttons now correctly navigate to the next and previous months, ensuring consistent behavior across all locales and layouts. (#4541)
2 changes: 1 addition & 1 deletion packages/components/calendar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"peerDependencies": {
"@heroui/system": ">=2.4.0",
"@heroui/theme": ">=2.4.0",
"@heroui/theme": ">=2.4.7",
"framer-motion": ">=11.5.6 || >=12.0.0-alpha.1",
"react": ">=18 || >=19.0.0-rc.0",
"react-dom": ">=18 || >=19.0.0-rc.0"
Expand Down
17 changes: 13 additions & 4 deletions packages/components/calendar/src/calendar-base.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {VisuallyHidden} from "@react-aria/visually-hidden";
import {Button} from "@heroui/button";
import {chain, mergeProps} from "@react-aria/utils";
import {AnimatePresence, LazyMotion, MotionConfig} from "framer-motion";
import {useLocale} from "@react-aria/i18n";
import {ResizablePanel} from "@heroui/framer-utils";

import {ChevronLeftIcon} from "./chevron-left";
Expand Down Expand Up @@ -70,20 +71,26 @@ export function CalendarBase(props: CalendarBaseProps) {

const [direction, setDirection] = useState<number>(0);

const {direction: localeDirection} = useLocale();

const currentMonth = state.visibleRange.start;

const headers: React.ReactNode[] = [];
const calendars: React.ReactNode[] = [];

const isRTL = localeDirection === "rtl";

for (let i = 0; i < visibleMonths; i++) {
let d = currentMonth.add({months: i});

headers.push(
<Fragment key={`calendar-header-${i}`}>
{i === 0 && (
<Button
{...prevButtonProps}
onPress={chain(prevButtonProps.onPress, () => setDirection(-1))}
{...(isRTL ? nextButtonProps : prevButtonProps)}
onPress={chain(isRTL ? nextButtonProps.onPress : prevButtonProps.onPress, () =>
setDirection(-1),
)}
>
<ChevronLeftIcon />
</Button>
Expand All @@ -96,8 +103,10 @@ export function CalendarBase(props: CalendarBaseProps) {
/>
{i === visibleMonths - 1 && (
<Button
{...nextButtonProps}
onPress={chain(nextButtonProps.onPress, () => setDirection(1))}
{...(isRTL ? prevButtonProps : nextButtonProps)}
onPress={chain(isRTL ? prevButtonProps.onPress : nextButtonProps.onPress, () =>
setDirection(1),
)}
>
<ChevronRightIcon />
</Button>
Expand Down
5 changes: 4 additions & 1 deletion packages/components/calendar/src/use-calendar-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ export function useCalendarBase(originalProps: UseCalendarBasePropsComplete) {

const globalContext = useProviderContext();

const {locale} = useLocale();
const {locale, direction} = useLocale();

const isRTL = direction === "rtl";

const calendarProp = createCalendar(new DateFormatter(locale).resolvedOptions().calendar);

Expand Down Expand Up @@ -261,6 +263,7 @@ export function useCalendarBase(originalProps: UseCalendarBasePropsComplete) {
isRange: !!originalProps.isRange,
isHeaderWrapperExpanded: isHeaderExpanded,
className,
isRTL,
}),
[objectToDeps(variantProps), showMonthAndYearPickers, isHeaderExpanded, className],
);
Expand Down
8 changes: 8 additions & 0 deletions packages/core/theme/src/components/calendar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,20 @@ const calendar = tv({
pickerItem: "transition-opacity",
},
},
isRTL: {
true: {
nextButton: "order-1",
prevButton: "order-3",
},
false: {},
},
},
defaultVariants: {
color: "primary",
showShadow: false,
hideDisabledDates: false,
showMonthAndYearPickers: false,
isRTL: false,
},
compoundVariants: [
// !isRange & colors --> Calendar
Expand Down