-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fn win alt keys #4638
Conversation
🦋 Changeset detectedLatest commit: 98f63ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces support for additional keyboard keys (Fn, Win, and Alt) in the Keyboard (Kbd) component across multiple files. This enhancement expands the existing keyboard key functionality by updating type definitions, key mappings, and Storybook configuration to include the new key types. The changes are consistent across documentation, component utilities, and component stories. Changes
Assessment against linked issues
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/components/kbd/src/utils.ts (1)
45-47
: Consider using a more appropriate symbol for the Windows key.Currently, the Windows key uses "⌘" which is typically associated with the Command key on Mac. This could be confusing for users. Consider using a more platform-agnostic symbol like "⊞" for the Windows key.
- win: "⌘", + win: "⊞",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.changeset/stale-tips-kneel.md
(1 hunks)apps/docs/content/docs/components/kbd.mdx
(1 hunks)packages/components/kbd/src/utils.ts
(3 hunks)packages/components/kbd/stories/kbd.stories.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: TypeScript
- GitHub Check: Build
🔇 Additional comments (4)
packages/components/kbd/stories/kbd.stories.tsx (1)
34-36
: LGTM! New key options added consistently.The addition of "fn", "win", and "alt" options aligns with the type definitions and maintains consistency across the component.
packages/components/kbd/src/utils.ts (1)
70-72
: LGTM! Clear and consistent key labels.The label mappings use standard keyboard terminology that will be familiar to users.
.changeset/stale-tips-kneel.md (1)
1-5
: LGTM! Appropriate version bump and clear reference to issue.The patch version bump is appropriate for this feature addition, and the changeset correctly references the related issue.
apps/docs/content/docs/components/kbd.mdx (1)
115-118
: LGTM! Documentation updated consistently.The KbdKey type definition in the documentation has been updated to match the implementation, maintaining consistency across the codebase.
Closes #4499
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
New Features
Documentation