fix: 304 status code return error #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzekin
previously approved these changes
Jun 30, 2023
Duslia
force-pushed
the
fix/body_status_not_allow
branch
from
ec45b07 to
b8bcf26
Compare
wzekin
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it (English/Chinese):
en: The error occurred with the 304 status code. The 304 status code is not considered an error per se, as it indicates that the requested resource has not been modified since the last request. However, in HTTP/2, the 304 status code is treated as an error in terms of handling, where it does not allow for a response body to be returned.
zh: 304 状态码返回了 error。304 状态码只是不允许返回 body，不是请求错误，但是在 h2 当中把 304 状态码当作错误处理了。
Which issue(s) this PR fixes: