Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ko is erroneously detected (again) #2

Closed
herzbube opened this issue Dec 9, 2012 · 2 comments
Closed

Ko is erroneously detected (again) #2

herzbube opened this issue Dec 9, 2012 · 2 comments
Assignees
@herzbube
Labels
bug user feedback
Milestone
0.9.1

Comments

@herzbube
Copy link
Owner

herzbube commented Dec 9, 2012

A user reports this via in-game bugreport function:

-------- Original Message --------
Subject: Little Go Bug Report
Date: 08.12.2012 21:06
From: email address omitted
To: "herzbube@herzbube.ch" herzbube@herzbube.ch

Hi,

I believe I have found a bug in your iOS app Little Go. This is what I have found out about the problem.

Description: After WJ7 white started a ko fight but I'm unable to play BH7 and take white J7.

Steps to reproduce:

  1. BJ8
  2. WJ7
  3. BH7 !!!

Thanks for having a look at this.

screenshot.png
@ghost ghost assigned herzbube Dec 9, 2012
@herzbube
Copy link
Owner Author

herzbube commented Dec 9, 2012

There is indeed an embarassing bug in the method that tries to detect Ko (method isLegalMove:() in class GoGame). The condition that is not checked by the Ko detection logic is whether the opposing stone (J7 in the bug report) actually did a capture in the previous move.

@herzbube herzbube mentioned this issue Dec 11, 2012
Closed
@herzbube
Copy link
Owner Author

Closing this issue, 0.9.1 has been released

herzbube added a commit that referenced this issue Mar 12, 2021
@herzbube
GameActionManager now performs delayed updates on main thread (#364)
8135976 
linked crash reports
- Xcode Organizer
  - Crash report batch #1, consisting of 4 crash reports from a single
    device (an iPhone 8) running iOS 14.4.
- Crashlytics
  - Crash report batch #2, consisting of 1 crash report from an iPhone 8
    device running iOS 14.4.

all crashes occurred in method updateNavigationBarWidths of
NavigationBarControllerPhonePortraitOnly, on this line:
  [self.view removeConstraints:constraintsToRemove];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herzbube herzbube

Labels
bug user feedback
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
1 participant
@herzbube