migrate to Qt6, Botan 3, make it work on macOS #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jlopez
commented
Jun 12, 2024
jlopez
commented
- fix: switch to qmake
- fix: seek_dir -> seekdir
- fix: botan 3 include/lib locations
- fix: ensure c++20 std
- fix: migrate to botan-3
- fix: ensure c++20 std
- fix: remove softkeys from mainwindow.ui
- fix: case insensitive issue on top Makefile
- fix: remove unnecessary botan initialization
- fix: add .qmake.stash to .gitignore
- fix: pixmap is no longer a pointer
- fix: QRegExp to QRegularExpression
- fix: switch to UTF-8 encoding
- fix: update QDate methods
- fix: setItemHidden -> setHidden
- fix: add include for QStandardPaths
- fix: implicit QChar assignment from int
- fix: QNetworkInformation reachability
- fix: QRegularExpression new API
- fix: use std::sort instead of qSort
- fix: QByteArray and QString interactions
- fix: QString sprintf deprecation
- fix: rename of QPalette::background() -> window()
- fix: update QDate methods (tbs)
- fix: missing imports
- fix: QFontMetrics::width -> horizontalAdvance
- fix: QPainter::drawRoundRect -> drawRoundedRect
- fix: ensure unix botan libs not used on mac
- fix: init QNetworkInformation to avoid crash
- chore: add vscode config files
Open
|
Address issue #95 |
hetelek
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Thanks for doing this! Could you update this COMPILING.md to include updated instructions? Seems it's referencing Qt 4.8.1
There was a problem hiding this comment.
Just pushed a new commit updating COMPILING.md
There was a problem hiding this comment.
Just pushed a new commit updating COMPILING.md
The link for the precompiled Botan library in that readme is still for the old version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.