windows build fixed #109
Merged
windows build fixed #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed Phonon dependency.
usage of QVariant::type() is deprecated in favor of metaType() usage of memcpy is Unsafe for Non-Trivial Types and not intentional. replaced with assignment operators or std::copy where needed.
When you use new[] to allocate an array of objects, you must use delete[] to deallocate that memory. Using delete without the brackets is incorrect and can lead to undefined behavior, including memory leaks or crashes, because delete doesn't know it's dealing with an array and won't properly call destructors for each element in the array.
Quick hack to enforcing light mode (on windows?) until dark mode is properly implemented to aid in text visibility issues. (e.g. Tools/Profile Tools/Profile Cleaner has no text visible)
using toLocalFile() will work across Windows, Linux, and macOS. This method is designed to handle the conversion of a QUrl to a local file path in a platform-independent manner.
Changed the OS declaration for Windows to reflect the LIB path in Velocity.pro.
allows to compile on windows platform with mingw32-make instead of make.
__WIN32__ is not a std macro to detect windows. replaced with "_WIN32"
Since compiling with VC++ is no longer maintained, removed traces of MSC_VER, in favor of building with MINWG
configuring Settings/Preferences/Package Drop Action to Rehash/Resign, would try to resigning LIVE, PIR and CON files, leading to a error. judging from the logic in packageviewer.cpp, LIVE and PIR containers like avatar items need only a rehash. This fixes mass (drag-drop) rehashing.
hetelek
reviewed
Oct 28, 2024
| @@ -9,22 +9,6 @@ About::About(QWidget *parent) : | |||
| setFixedSize(sizeHint()); | |||
| setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint); | |||
| QtHelpers::GenAdjustWidgetAppearanceToOS(this); | |||
|
|
|||
| #ifdef _WIN32 | |||
| if (!QFile::exists(QtHelpers::ExecutingDirectory() + "Developers.mp3")) | |||
There was a problem hiding this comment.
Why remove this? Would prefer to keep it, it's a nice easter egg
There was a problem hiding this comment.
I'm generally in favor of removing dependencies if this allows us to remove Phonon. Maybe we can use QMediaPlayer to play it?
hetelek
reviewed
Oct 28, 2024
| package->Resign(QtHelpers::GetKVPath(package->metaData->certificate.ownerConsoleType, this)); | ||
| if (fileMagic == CON) | ||
| { | ||
| package->Resign(QtHelpers::GetKVPath(package->metaData->certificate.ownerConsoleType, this)); |
There was a problem hiding this comment.
Curious what effect this was having previously? Was it corrupting some files?
|
@Pandoriaantje would you mind sharing the binaries? |
|
Have not tested this much, but I was at least able to build and run on Windows. I will merge this and we can follow up with more PRs if necessary. Thank you @Pandoriaantje ! |
@DerfJagged I just uploaded Windows binaries at https://github.com/hetelek/Velocity/releases/tag/v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some fixes to build on windows platform, using Botan >= 3.4 (tested with latest Botan 3.5).
Builds fine with QT 6.7.3 MingGW 11.2.0 and above.