Refactor CLI commands into multiple packages #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for splitting up cmds into multiple packages.
LKaemmerling
approved these changes
Jan 11, 2021
LKaemmerling
approved these changes
Jan 12, 2021
mfrister
force-pushed
the
refactor-multiple-packages
branch
from
63580f5 to
9bbdf54
Compare
Preparation for splitting up cmds into multiple packages.
Remove the package name from all function names.
mfrister
force-pushed
the
refactor-multiple-packages
branch
from
9bbdf54 to
0110707
Compare
phm07
added a commit
that referenced
this pull request
Jan 9, 2024
The `--poll-interval` flag was ignored since a refactoring in #293 (released first in v1.21.0). This adds back the functionality that was lost then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all commands in a single package makes the structure hard to navigate and understand.
This PR changes the package structure in a way that resembles the structure of the CLI commands, with one package per top-level CLI command.