Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: order by key when printing labels #960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 17, 2025

This PR adds sorting of labels by their keys, which is useful for testing, since iteration order over maps in Go is undefined by default.
It uses the Go 1.23 iteration feature. If we want to use this, we should probably bump the Go version in a separate PR.

@phm07 phm07 self-assigned this Jan 17, 2025
@phm07 phm07 requested a review from a team as a code owner January 17, 2025 16:15
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (d7fd0ca) to head (d3fc1ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/util/util.go 62.50% 2 Missing and 1 partial ⚠️
internal/cmd/loadbalancer/describe.go 0.00% 1 Missing ⚠️
internal/cmd/primaryip/describe.go 0.00% 1 Missing ⚠️
internal/cmd/server/describe.go 0.00% 1 Missing ⚠️
internal/cmd/volume/describe.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   70.01%   69.98%   -0.03%     
==========================================
  Files         245      245              
  Lines       10715    10716       +1     
==========================================
- Hits         7502     7500       -2     
- Misses       2537     2539       +2     
- Partials      676      677       +1     
Flag Coverage Δ
e2e 46.78% <57.89%> (+<0.01%) ⬆️
unit 63.43% <57.89%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant