refactor: split up label command into separate Fetch/GetLabels/GetIDOrName #967
+290
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
- Coverage 70.01% 63.69% -6.32%
==========================================
Files 245 243 -2
Lines 10715 10723 +8
==========================================
- Hits 7502 6830 -672
- Misses 2537 3178 +641
- Partials 676 715 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apricote
reviewed
Jan 28, 2025
internal/cmd/base/labels.go
Outdated
Comment on lines
23
to
26
| Fetch func(s state.State, idOrName string) (any, error) | ||
| SetLabels func(s state.State, resource any, labels map[string]string) error | ||
| GetLabels func(resource any) map[string]string | ||
| GetIDOrName func(resource any) string |
There was a problem hiding this comment.
We could make LabelCmds generic over the resource structs to get rid of the any here
There was a problem hiding this comment.
Good point, added that in 6d4faef. We could think about doing that for the other structs in internal/cmd/base as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended for an upcoming resource that has labels but doesn't have numeric IDs.