fix(routes): deleting wrong routes when other server has same private IP #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case another server in the project has the same Private IP (in another network) as one of our cluster nodes, hccm would happily delete&recreate the route on every route reconciliation. This fixes the bug by only adding the Private IPs in the correct network to the AllServersCache ByPrivateIP lookup map. Fixes #470 Co-authored-by: Jonas Lammler <ljonas@riseup.net>
apricote
force-pushed
the
fix-routes-flapping
branch
from
e0692e0 to
7581558
Compare
jooola
approved these changes
Jul 18, 2023
apricote
pushed a commit
that referenced
this pull request
Jul 18, 2023
🤖 I have created a release *beep* *boop* --- ## [1.17.0](v1.16.0...v1.17.0) (2023-07-18) ### Features * **helm:** allow to set labels and annotations for podMonitor ([#471](#471)) ([5dad655](5dad655)) * upgrade to hcloud-go v2 e4352ec ([5a066a1](5a066a1)) ### Bug Fixes * **helm-chart:** resource namespace and name ([#462](#462)) ([0c4eee6](0c4eee6)) * **routes:** deleting wrong routes when other server has same private IP ([#472](#472)) ([5461038](5461038)), closes [#470](#470) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case another server in the project has the same Private IP (in another network) as one of our cluster nodes, hccm would happily delete&recreate the route on every route reconciliation.
This fixes the bug by only adding the Private IPs in the correct network to the AllServersCache ByPrivateIP lookup map.
Fixes #470