fix(helm-chart): resource namespace and name #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Nice! Could you update the field in the ClusterRoleBinding to match the new name(+space) of the ServiceAccount?
apricote
approved these changes
Jun 29, 2023
Sorry i forgot to change it there. |
|
Sorry for the delay. Our e2e tests are currently broken for PRs from forks and I wanted to run them locally. I found that in the e2e tests we do not set the Helm Chart namespace which caused the pods to run in |
apricote
approved these changes
Jul 5, 2023
apricote
pushed a commit
that referenced
this pull request
Jul 18, 2023
🤖 I have created a release *beep* *boop* --- ## [1.17.0](v1.16.0...v1.17.0) (2023-07-18) ### Features * **helm:** allow to set labels and annotations for podMonitor ([#471](#471)) ([5dad655](5dad655)) * upgrade to hcloud-go v2 e4352ec ([5a066a1](5a066a1)) ### Bug Fixes * **helm-chart:** resource namespace and name ([#462](#462)) ([0c4eee6](0c4eee6)) * **routes:** deleting wrong routes when other server has same private IP ([#472](#472)) ([5461038](5461038)), closes [#470](#470) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue that you can change the release namespace with helm, but the deployment will not take care of it.
Also this allows the user to use the nameoverwrite that was already defined inside the chart helpers.