Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PTR update for load balancer #315

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix PTR update for load balancer #315

merged 2 commits into from
Sep 22, 2022

Conversation

ym
Copy link
Contributor

@ym ym commented Sep 15, 2022

IPv4.IP is net.IP, we should use .String() instead.

This should be able to fix the errors below:

E0915 21:16:48.820450       1 controller.go:310] error processing service traefik/traefik (will retry): failed to ensure load balancer: hcloud/loadBalancers.EnsureLoadBalancer: hcops/LoadBalancerOps.ReconcileHCLB: hcops/LoadBalancerOps.changeIPv4RDNS: could not parse ip address �����
I0915 21:16:46.665718       1 event.go:294] "Event occurred" object="haproxy/haproxy-private-cache-4-kubernetes-ingress" fieldPath="" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: hcloud/loadBalancers.EnsureLoadBalancer: hcops/LoadBalancerOps.ReconcileHCLB: hcops/LoadBalancerOps.changeIPv4RDNS: could not parse ip address \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xff\x05\xa1\xa0{"

@LKaemmerling
Copy link
Member

Hey @ym,

it looks like the tests fail, could you please fix them :)?

@ym
Copy link
Contributor Author

ym commented Sep 20, 2022

@LKaemmerling

Tests fixed and it looks fine from my dev env now:

run ^TestLoadBalancerOps_ReconcileHCLB$ github.com/hetznercloud/hcloud-cloud-controller-manager/internal/hcops

ok  	github.com/hetznercloud/hcloud-cloud-controller-manager/internal/hcops	(cached)

Copy link
Contributor

@4ND3R50N 4ND3R50N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LKaemmerling LKaemmerling merged commit 2538d3a into hetznercloud:main Sep 22, 2022
@ym
Copy link
Contributor Author

ym commented Oct 4, 2022

Thanks for your help in increasing the API limits, it does solve our problem 👍 @Kjarrigan @LKaemmerling
But I checked the logs and there are lots of retries due to the PTR update bug, is there any plan to release this bug fix?

@LKaemmerling
Copy link
Member

@ym we just released a new version that contains your fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants