refactor: unnecessary API call in instance reconciliation #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
force-pushed
the
network-api-call
branch
from
f313a11 to
9686f30
Compare
|
The network name is not being returned in the |
Calls to InstanceV2.InstanceMetadata() caused 2 API calls, one to retrieve the server and the second to check if the configured network exists. The second call is not necessary because we already know all networks that the server is attached to exist. By just comparing the nameOrID locally we can achieve the same result.
nodeAddresses does no longer require access to the HCloud API, and we can move it to a standalone function. This simplifies the tests and improves their performance as we no longer need the test env.
apricote
force-pushed
the
network-api-call
branch
from
9686f30 to
6bf23de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
InstanceV2.InstanceMetadata()caused 2 API calls, one to retrieve the server and the second to check if the configured network exists.The second call is not necessary because we already know all networks that the server is attached to exist. By just comparing the
nameOrIDlocally we can achieve the same result.Related to #384