ci: build helm repo index #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously relied on the helm-charts repo to re-build the index. But this has problems: - The gh-pages pipeline is not properly started because events created by the default GITHUB_TOKEN do not trigger pipelines (in the same repo). - Adding the chart and re-indexing happens in two commits, slightly obfuscating the chain of events - When running `helm repo index` it updates the created timestamp of all existing entries. While I have not seen any issues yet, there might be some clients that rely on this field.
samcday
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously relied on the helm-charts repo to re-build the index. But this has problems:
helm repo indexit updates the created timestamp of all existing entries. While I have not seen any issues yet, there might be some clients that rely on this field.