Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): wrong version published when two tags point to same commit #392

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

apricote
Copy link
Member

The tags v1.14.0-rc.2 and v1.14.0 point to the same commit. Goreleaser always releases v1.14.0-rc.2 and we don't get a proper v1.14.0 release.

By specifying the release that goreleaser should handle, we can rely on Github to specify the correct tag for the current workflow.

The tags v1.14.0-rc.2 and v1.14.0 point to the same commit. Goreleaser
always releases v1.14.0-rc.2 and we don't get a proper v1.14.0 release.

By specifying the release that goreleaser should handle, we can rely on
Github to specify the correct tag for the current workflow.
@apricote apricote added the bug Something isn't working label Mar 14, 2023
@apricote apricote self-assigned this Mar 14, 2023
@apricote apricote requested a review from a team as a code owner March 14, 2023 10:35
Copy link
Contributor

@samcday samcday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@apricote apricote merged commit b5e160a into main Mar 14, 2023
@apricote apricote deleted the fix-goreleaser-version branch March 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants