fix: handle nil servers in InstanceV2 #398 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcday
reviewed
Mar 17, 2023
samcday
approved these changes
Mar 17, 2023
We did not properly handle nil pointers returned from `lookupServer`. Based on the current usage in `k/cloud-provider` the methods are called in these contexts: - `InstanceShutdown` is only called for instances that actually do exist (as verified by a prior call to `InstanceExists`) - `InstanceMetadata` is called without verifying that the instance exists, one call site accepts a nil InstanceMetadata, but the other does not.
apricote
force-pushed
the
fix-nil-server
branch
from
3d3d52d to
81cbd38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not properly handle nil pointers returned from
lookupServer.Based on the current usage in
k/cloud-providerthe methods are called in these contexts:InstanceShutdownis only called for instances that actually do exist (as verified by a prior call toInstanceExists)InstanceMetadatais called without verifying that the instance exists, one call site accepts a nil InstanceMetadata, but the other does not.Closes Issues if lookupServer() returns nil server #398