refactor: Update & Fix golangci-lint #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine all CI workflows running on `push` & `pull_request` triggers into a single workflow and add golangci-lint to it.
Replace outdated linters and fix any issues that were present on the code.
samcday
approved these changes
Mar 28, 2023
|
@samcday Appreciate the approval, but I think e2e tests are broken right now, waiting for them to finish, |
|
Seems like the failure before the rebase was a flake (across all runs?). Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
golangci-lintconfiguration to replace any deprecated linters and fix issues that are present. This also includes issues that were present before this PR, as the linter was not running in our CI and quite a few issues creeped in over time.This also consolidates all the CI workflows running during
push&pull_requestsinto a single workflow with multiple jobs, as I personally find that easier to navigate in the web interface.