feat(load-balancer): Add new node-selector annotation #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dont worry about the failing e2e tests. They are currently broken for external contributors. I ran them locally and everything passed :) |
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
apricote
changed the title
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
|
Thanks for the fast review! Also thanks for adding explanations to all suggestions, too often this is missing and contributor don't understand the suggestions or cant learn from it. |
apricote
approved these changes
Sep 14, 2023
apricote
pushed a commit
that referenced
this pull request
Sep 18, 2023
🤖 I have created a release *beep* *boop* --- ## [1.18.0](v1.17.2...v1.18.0) (2023-09-18) ### Features * build with Go 1.21 ([#516](#516)) ([7bf7e71](7bf7e71)) * **chart:** configure additional tolerations ([#518](#518)) ([0d25cb6](0d25cb6)), closes [#512](#512) * **chart:** support running multiple replicas with leader election ([4b18ee5](4b18ee5)) * **load-balancer:** Add new node-selector annotation ([#514](#514)) ([db2e6dc](db2e6dc)) * test against kubernetes v1.28 and drop v1.24 ([#500](#500)) ([3adf781](3adf781)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #506, #373