fix: request flood when misconfigured cluster-cidr causes dead routes to be kept #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 70.29% 70.39% +0.10%
==========================================
Files 31 31
Lines 3205 3216 +11
==========================================
+ Hits 2253 2264 +11
Misses 779 779
Partials 173 173 ☔ View full report in Codecov by Sentry. |
… to be kept Check if route CIDR is contained in cluster CIDR before adding the route and return an error if it is not contained.
lukasmetzner
force-pushed
the
482-fix-request-flood-when-misconfigured-cluster-cidr-causes-dead-routes-to-be-kept
branch
from
782d685 to
addd861
Compare
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
jooola
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a route, verify if the route CIDR is contained within the cluster CIDR. If it is not, return an error to prevent a flood of requests caused by persistent dead routes.
Fixes #482