[Backport release-1.x] feat(iso): support deprecation info API (#333)

Backport b3a3621 from #331. Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
hetznercloud · Oct 12, 2023 · 5f89c57 · 5f89c57
1 parent f2d5292
commit 5f89c57
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/hcloud/iso.go b/hcloud/iso.go
@@ -17,12 +17,9 @@ type ISO struct {
 	Description  string
 	Type         ISOType
 	Architecture *Architecture
-	Deprecated   time.Time
-}
-
-// IsDeprecated returns true if the ISO is deprecated.
-func (iso *ISO) IsDeprecated() bool {
-	return !iso.Deprecated.IsZero()
+	// Deprecated: Use [ISO.Deprecation] instead.
+	Deprecated time.Time
+	DeprecatableResource
 }
 
 // ISOType specifies the type of an ISO image.

diff --git a/hcloud/iso_test.go b/hcloud/iso_test.go
@@ -20,7 +20,7 @@ func TestISOIsDeprecated(t *testing.T) {
 
 	t.Run("deprecated", func(t *testing.T) {
 		iso := &ISO{
-			Deprecated: time.Now(),
+			DeprecatableResource: DeprecatableResource{Deprecation: &DeprecationInfo{Announced: time.Now()}},
 		}
 		if !iso.IsDeprecated() {
 			t.Errorf("unexpected value for IsDeprecated: %v", iso.IsDeprecated())

diff --git a/hcloud/schema.go b/hcloud/schema.go
@@ -124,6 +124,9 @@ func ISOFromSchema(s schema.ISO) *ISO {
 		Description: s.Description,
 		Type:        ISOType(s.Type),
 		Deprecated:  s.Deprecated,
+		DeprecatableResource: DeprecatableResource{
+			DeprecationFromSchema(s.Deprecation),
+		},
 	}
 	if s.Architecture != nil {
 		iso.Architecture = Ptr(Architecture(*s.Architecture))

diff --git a/hcloud/schema/iso.go b/hcloud/schema/iso.go
@@ -10,6 +10,7 @@ type ISO struct {
 	Type         string    `json:"type"`
 	Architecture *string   `json:"architecture"`
 	Deprecated   time.Time `json:"deprecated"`
+	DeprecatableResource
 }
 
 // ISOGetResponse defines the schema of the response when retrieving a single ISO.