feat(servertype): implement new Deprecation api field #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
force-pushed
the
server-type-deprecation
branch
from
e91b869 to
1ed156c
Compare
This was referenced Jun 6, 2023
|
Linting will be fixed by #269 |
apricote
force-pushed
the
server-type-deprecation
branch
from
1ed156c to
2976dca
Compare
We recently added a new Field to the ServerType API response that indicates if and when the server type was deprecated. The same structure will also be used for other resources in the future, replacing the current "deprecated" fields.
apricote
force-pushed
the
server-type-deprecation
branch
from
2976dca to
16e2708
Compare
Argument layout of mustParseTime was always set to the same value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a new field to the ServerType API response that indicates if and when the server type was deprecated. The same structure will also be used for other resources in the future, replacing the current
deprecatedfields.Marked as draft until I have finished the implementation in our other Go Integrations, to make sure that this feels ergonomic.