ci: fix linting issues #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of golangci-lint updated depguard, which in turn started erroring because it was missing a config. Previously depguard did not do anything as we never configured a list of allowed/denied imports. In general, we already have gomodguard for linting imports. To avoid sudden breakages of our CI in the future, I pinned the exact version of golangci-lint to the current release. Upgrading this should hppen through a PR process (e.g. by renovate) so we can notice new linting failures and fix them before merging to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of golangci-lint updated depguard, which in turn started erroring because it was missing a config. Previously depguard did not do anything as we never configured a list of allowed/denied imports.
In general, we already have gomodguard for linting imports.
To avoid sudden breakages of our CI in the future, I pinned the exact version of golangci-lint to the current release. Upgrading this should hppen through a PR process (e.g. by renovate) so we can notice new linting failures and fix them before merging to main.