Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update module github.com/prometheus/client_golang to v1.19.0 #388

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 27, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus/client_golang v1.18.0 -> v1.19.0 age adoption passing confidence

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.19.0

Compare Source

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See https://github.com/prometheus/client_golang/pull/1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #​1445 #​1449
  • [FEATURE] collectors: Add version collector. #​1422 #​1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner February 27, 2024 21:27
@renovate renovate bot force-pushed the renovate/github.com-prometheus-client_golang-1.x branch 2 times, most recently from 03e0818 to ab85c6a Compare March 4, 2024 09:10
@jooola
Copy link
Member

jooola commented Mar 4, 2024

https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md#1190--2023-02-27

Minimum required go version is now 1.20

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See https://togithub.com/prometheus/client_golang/pull/1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

@jooola jooola mentioned this pull request Mar 4, 2024
jooola added a commit that referenced this pull request Mar 4, 2024
This follows our Go version policy
https://github.com/hetznercloud/hcloud-go#go-version-support, but we
don't want to force an unjustified go version upgrade for users of this
library, so we only require go 1.20 instead of go 1.21.

The prometheus client_golang bumped the required go version to 1.20, we
need to follow to be able to upgrade this dependency:
#388
@jooola jooola force-pushed the renovate/github.com-prometheus-client_golang-1.x branch from ab85c6a to d7d4e1f Compare March 4, 2024 09:50
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (299f181) to head (d7d4e1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files          32       32           
  Lines        5722     5722           
=======================================
  Hits         4598     4598           
  Misses        717      717           
  Partials      407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 03e7089 into main Mar 4, 2024
4 checks passed
@jooola jooola deleted the renovate/github.com-prometheus-client_golang-1.x branch March 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant