Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure all join types are parsed correctly #10

Merged
merged 11 commits into from
Dec 5, 2023
Merged

ensure all join types are parsed correctly #10

merged 11 commits into from
Dec 5, 2023

Conversation

dylanscott
Copy link

@dylanscott dylanscott commented Dec 5, 2023 •
edited
Loading

This PR builds on hex-inc/sqlparse#9 to ensure that all duckdb join types are parsed correctly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7107253881

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7063907240: 0.0%
Covered Lines: 890
Relevant Lines: 890
💛 - Coveralls

@dylanscott dylanscott requested a review from jkillian December 5, 2023 15:02
@dylanscott dylanscott merged commit b076e89 into master Dec 5, 2023
6 checks passed
@dylanscott dylanscott deleted the dscott/join-types branch December 5, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkillian jkillian jkillian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanscott @jkillian