use sqlparse position tracking #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkillian
approved these changes
Sep 25, 2023
pyproject.toml
Outdated
| @@ -1,24 +1,26 @@ | |||
| [tool.poetry] | |||
| name = "sql_metadata" | |||
| version = "2.8.0" | |||
| license="MIT" | |||
| license = "MIT" | |||
There was a problem hiding this comment.
All these formatting changes in this file seem like changes we might not want if it makes it differ from upstream?
There was a problem hiding this comment.
sorry I think this was an overzealous vs code toml formatter - will revert the formatting changes
dylanscott
force-pushed
the
dscott/sync-fork
branch
from
7c3b07e to
2b5dd1e
Compare
dylanscott
force-pushed
the
dscott/use-sqlparse-positions
branch
from
6a55a75 to
10c065a
Compare
Pull Request Test Coverage Report for Build 6341838340
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the version of sqlparse from hex-inc/sqlparse#4 and reverts the old position tracking implementation that we added and replaces it with a much simpler version that uses the token positions and lengths now provided by sqlparse. I'm doing some dev work on the ast-service with these new versions pulled in and have confirmed that they do not regress any tests