Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http_client Response body property generic - part of #369 #448

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

mattTea
Copy link

@mattTea mattTea commented Nov 6, 2021

Make Response body property generic within http_client package. This is part of the TODO Hunting issue #369


For the Pull Request to be accepted please check:

  • The PR has a meaningful title.
  • If the PR refers to an issue, it should be referenced with the GitHub format (#ID).
  • The PR is done to the develop branch (new features) or the master branch (releases).
  • The code pass all PR checks.
  • All public members are documented using KDoc.
  • The code follow the coding conventions stated at the contributing.md file.

jaguililla and others added 2 commits November 1, 2021 17:33
Existing uses retain Response as type String
@jaguililla
Copy link
Member

I was offline since Friday... I'll review this PR along this week, sorry for the delay, and thank you for the contribution!

@mattTea
Copy link
Author

mattTea commented Nov 9, 2021

No probs at all! 🙂

@jaguililla
Copy link
Member

Nice job... Thanks!!! :)

@jaguililla jaguililla merged commit 2fce52b into hexagontk:develop Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants