Refactoring - Better HTTP responses and streams handling, and test coverage #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… } according to the http docker status.
|
Awesome, glad to hear this was useful for you! I just got back from some traveling and haven't had a chance to look through your changes yet. I'm definitely interested in getting them merged and I'll try to read through everything this week. |
|
Hey there, Did you have time to read the code? Let me know if you have any questions! Looking forward to hear from you again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for what you've done! I use this package in an application at work, but we needed to refactor it a lot in order to make it work. We tried to make it more reusable and included a lot more unit tests.
I suggest this PR just so you can review the code. Let me know if you're interested in such pull requests.
If you do, I will take time to finish the tests and the documentation, and we can figure out together which conventions we should follow.
Looking forward to hear from you :)