Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require at least node 8 #16

Merged
merged 5 commits into from
Jul 10, 2019
Merged

chore: require at least node 8 #16

merged 5 commits into from
Jul 10, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jun 29, 2019

  • add support for ES2019 (through eslint-plugin-node@9, see next comment)
    • Node 8 only partially supports ES2018 and ES2019, node 8 in travis (of other repos that uses this) should fail when using unsupported es2018/es2019 features.
  • update to eslint-plugin-node@9 to support node 12. It still supports eslint@5, but requires >=8.10.0 which is higher than hexo's (Drop NodeJs 6 support & Require NodeJs >= 8.6 hexo#3508 (comment)). eslint-plugin-node@8 may be safer.
  • ignore nyc logs and package-lock. "coverage/" is used by the deprecated istanbul.

@curbengh
Copy link
Contributor Author

The config eslint.js may requires some changes.

@curbengh curbengh mentioned this pull request Jun 29, 2019
1 task
@curbengh
Copy link
Contributor Author

curbengh commented Jun 29, 2019

just noticed eslint-plugin-node@9 defaults to ecmaversion 2019, so that value is not needed here. Tested with hexojs/hexo-generator-sitemap#46.

{ "env": { "es6": true } } is still required for new ES6 global variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants