Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for package.yaml #512

Closed
wants to merge 5 commits into from

Conversation

sghuang19
Copy link

@sghuang19 sghuang19 commented Aug 15, 2024

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

Support package.yaml when checking package file with hexo in it.

Additional information

Originally proposed in hexojs/hexo#5534. Also solves #511.

Could be useful for pnpm users who prefers package.yaml.

resolves hexojs/hexo#5534
resolves #511

package.json Outdated Show resolved Hide resolved
lib/find_pkg.ts Outdated Show resolved Hide resolved
@sghuang19 sghuang19 marked this pull request as ready for review August 15, 2024 19:09
@sghuang19
Copy link
Author

Passed tests for:

  • Both package.json and package.yaml exists and has hexo in it.
  • Both exist but only one has hexo in it.
  • Both exist and none has hexo.
  • Searching for package.json and package.yaml in dir above.

@sghuang19 sghuang19 requested a review from SukkaW August 15, 2024 19:12
@sghuang19
Copy link
Author

This actually shortened the code, which is quite elegant imo. 😆

@coveralls
Copy link

Coverage Status

coverage: 92.692% (+0.3%) from 92.395%
when pulling d57ca49 on sghuang19:feature/package-yaml
into 267b149 on hexojs:master.

@sghuang19
Copy link
Author

Seems like I forgot to handle hexo init, will continue to fix this problem.

@sghuang19 sghuang19 marked this pull request as draft August 17, 2024 17:05
@sghuang19 sghuang19 closed this Aug 17, 2024
@pplmx
Copy link

pplmx commented Oct 1, 2024

Any progress?

@sghuang19
Copy link
Author

Any progress?

This change affects more moving parts than I thought. Not moving forward for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pnpm/package.yaml Add support for pnpm/package.yaml
4 participants