-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for package.yaml #512
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
requested changes
Aug 15, 2024
sghuang19
force-pushed
the
feature/package-yaml
branch
from
August 15, 2024 19:09
861e3a6
to
d57ca49
Compare
Passed tests for:
|
This actually shortened the code, which is quite elegant imo. 😆 |
Seems like I forgot to handle |
Any progress? |
This change affects more moving parts than I thought. Not moving forward for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check list
Description
Support
package.yaml
when checking package file withhexo
in it.Additional information
Originally proposed in hexojs/hexo#5534. Also solves #511.
Could be useful for pnpm users who prefers package.yaml.
resolves hexojs/hexo#5534
resolves #511