Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README.md #151

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update the README.md #151

merged 3 commits into from
Apr 3, 2024

Conversation

pbw-Kevin
Copy link
Contributor

No description provided.

@pbw-Kevin
Copy link
Contributor Author

While the new version of this plugin based on a new library,the application will not delete files and directories any more.

@pbw-Kevin
Copy link
Contributor Author

And the parameters clear and verbose in official docs become invalid. Should those be updated?

@stevenjoezhang
Copy link
Member

clear and verbose are still used:

if (args.clear) await client.clearWorkingDir();

client.ftp.verbose = args.verbose || false;

If these options are not working as expected, it could mean there is a bug.

@stevenjoezhang
Copy link
Member

You can modify the documentation to say:

If `clear` is set to true, this plugin will delete files and directories on the remote server to match the local machine. Use this plugin in production at your own risk.

@pbw-Kevin
Copy link
Contributor Author

Well, it seems that it's my fault.
After reinstall all the dependencies, every thing works well.
README.md has changed. Sorry for my rudeness.

@stevenjoezhang
Copy link
Member

Thank you, I'm glad to hear that the plugin is working well. If you encounter any issues, please feel free to report back!

@stevenjoezhang stevenjoezhang merged commit eb0f732 into hexojs:master Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants