Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overload type #186

Merged
merged 1 commit into from
Apr 13, 2024
Merged

fix: overload type #186

merged 1 commit into from
Apr 13, 2024

Conversation

D-Sketon
Copy link
Member

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

Additional information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8671080835

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 8559600268: 0.0%
Covered Lines: 582
Relevant Lines: 582
💛 - Coveralls

@D-Sketon
Copy link
Member Author

after this PR we can release a new version

stevenjoezhang
stevenjoezhang approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SukkaW SukkaW merged commit 67c8a6e into hexojs:master Apr 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D-Sketon @coveralls @stevenjoezhang @SukkaW