Reduce scope such as recursive function #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just by calling checkParent() once, directories up to their parents have been created and it is not necessary to put them in recursion.
Erase unnecessary type check.
Since the recursive function is an internal function, default arguments are unnecessary if used correctly within one file.
There is no problem if you return a string that does not collide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javascript is hard to optimize for recursive functions.
It would be hopeless to optimize asynchronous functions that span many lines of complexity and do not use async/await.
Therefore, we will try to reduce the complexity by making the recursion place as simple as possible.